-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show debug message if fee recipient from builder differs from registration #6024
Conversation
Ah the catch here is that it's generally expected that the builder won't set the actual fee recipient to the supplied value. They can build a block in advance of knowing who the fee recipient is (giving them more time) using their own fee recipient then just insert one last transaction into the block to transfer the payment to the requested fee recipient. It may still be worth having an option to warn in this situation but it's not a clear sign of a dishonest builder (it probably indicates a smart builder optimising things well). |
Ah I understand, that makes sense. Do you want an experimental option to enable this warning? I would also tone down the severity of the message and make it shorter. I'm not sure how useful it would be now though. |
I don't really know what we should do here. I lean towards not bothering but I'm not the MEV expert. @StefanBratanov and @benjaminion any thoughts? |
Hey, i remember having a discussion about this when the I think though actually it could be useful to add this log statement as |
@StefanBratanov thanks! I think a debug message makes more sense and I agree that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
PR Description
Noticed that there was no fee recipient check for execution payloads from a builder. It is possible that a dishonest builder could set this to a different address. I'm not entirely sure that showing a warning and proceeding is the correct thing to do. Maybe we should fall back to the local execution engine.
Documentation
doc-change-required
label to this PR if updates are required.Changelog